This code goes into an infinite loop! What am i doing wrong? There is only one post called “hello there”. The only way to stop it is use break; in while.

Any help appreciated

 $gotop="hello there";

$args = array(

    's' => $gotop,
    'post_type' => 'post'

);

$wp_query = new WP_Query($args);

if ( $wp_query->have_posts() ) :  ?>

        <?php

        while ( $wp_query->have_posts() ) {
      $wp_query->the_post();
}

else:
  echo "nothing found.";
endif;
?>

This code goes into an infinite loop! What am i doing wrong? There is only one post called “hello there”. The only way to stop it is use break; in while.

Any help appreciated

 $gotop="hello there";

$args = array(

    's' => $gotop,
    'post_type' => 'post'

);

$wp_query = new WP_Query($args);

if ( $wp_query->have_posts() ) :  ?>

        <?php

        while ( $wp_query->have_posts() ) {
      $wp_query->the_post();
}

else:
  echo "nothing found.";
endif;
?>

• wp-query

Share Improve this question asked Jun 28, 2019 at 10:54 stefanosnstefanosn 13399 bronze badges 3

• Don't use $wp_query as the variable name for your custom query. It's reserved for the main query. Can I ask why you're using a custom query for search? Is this your search.php template? – Jacob Peattie Commented Jun 28, 2019 at 11:16
• i need custom query. i have to search for 'hello there' in my content-single.php – stefanosn Commented Jun 28, 2019 at 11:48
• you were right the $wp_query was the issue. i renamed it and worked! please write the answer to accept it! – stefanosn Commented Jun 28, 2019 at 11:53

Add a comment  | 

3 Answers 3

Sorted by: Reset to default 2

I'm not certain why it would cause an infinite loop, but make sure not to use $wp_query as the variable name for your custom query. It's a reserved global variable for the main query. Use a different name for the variable. I'd also suggest using wp_reset_postdata() after the loop:

$my_query = new WP_Query( $args );

if ( $my_query->have_posts() ) :
    while ( $my_query->have_posts() ) {
        $my_query->the_post();
    }
else:
  echo "nothing found.";
endif;

wp_reset_postdata();

add wp_reset_query(); after while loop.

$gotop="hello there";

$args = array(

    's' => $gotop,
    'post_type' => 'post'

);

$my_query = new WP_Query($args);

if ( $my_query->have_posts() ) :  

        while ( $my_query->have_posts() ) {
             $my_query->the_post();
        }
        wp_reset_query();

else:
  echo "nothing found.";
endif;

let me know if this works for you!

According to WP codex, have_posts() will return True on success, false on failure. Calling this function within the loop will cause an infinite loop. So you need to use endwhile;

    $gotop="hello there";

$args = array(

    's' => $gotop,
    'post_type' => 'post'

);

$wp_query = new WP_Query($args);

if ( $wp_query->have_posts() ) :  ?>

        <?php

        while ( $wp_query->have_posts() ) {
      $wp_query->the_post();
      endwhile;
}

else:
  echo "nothing found.";
endif;
?>