I have following function in jQuery to format the number into ma-formatted:

function CommaFormattedN(amount) {

    var delimiter = ","; 
    var i = parseInt(amount);

    if(isNaN(i)) { return ''; }

    i = Math.abs(i);

    var minus = '';
    if (i < 0) { minus = '-'; }

    var n = new String(i);
    var a = [];

    while(n.length > 3)
    {
        var nn = n.substr(n.length-3);
        a.unshift(nn);
        n = n.substr(0,n.length-3);
    }

    if (n.length > 0) { a.unshift(n); }

    n = a.join(delimiter);

    amount = minus + n;

    return amount;

}

I am calling this function like this on

 $('.text_field1').bind("focus blur change keyup", function(){    
 var $el = $(this);
    $el.val(CommaFormattedN($el.val()));
});

It's working fine, but the problem is, when number of digits increase from 5, it makes nothing. All digits are deleted and it starts again.

I have following function in jQuery to format the number into ma-formatted:

function CommaFormattedN(amount) {

    var delimiter = ","; 
    var i = parseInt(amount);

    if(isNaN(i)) { return ''; }

    i = Math.abs(i);

    var minus = '';
    if (i < 0) { minus = '-'; }

    var n = new String(i);
    var a = [];

    while(n.length > 3)
    {
        var nn = n.substr(n.length-3);
        a.unshift(nn);
        n = n.substr(0,n.length-3);
    }

    if (n.length > 0) { a.unshift(n); }

    n = a.join(delimiter);

    amount = minus + n;

    return amount;

}

I am calling this function like this on

 $('.text_field1').bind("focus blur change keyup", function(){    
 var $el = $(this);
    $el.val(CommaFormattedN($el.val()));
});

It's working fine, but the problem is, when number of digits increase from 5, it makes nothing. All digits are deleted and it starts again.

• javascript
• jquery
• numbers

Share Improve this question Follow edited Jul 10, 2015 at 12:02 Salman Arshad 273k8484 gold badges444444 silver badges534534 bronze badges asked Feb 9, 2011 at 6:54 airair 6,2642626 gold badges9595 silver badges126126 bronze badges

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 6

You can use Number.toLocaleString() function to format a number into a locale specific format. Note that the output of the function varies with regional settings:

var n = parseInt("-123456789", 10);
console.log(n.toLocaleString())
// returns -123,456,789 on my puter (english-us locale)
// returns -123 456 789 for french locale
// returns -123.456.789 for german locale
// returns -123'456'789 for romansh (???) locale

1. There is a bug related to sign. You are using absolute value instead of original one.
2. Your code seems to work fine, you can try debugging the way you are calling your function.

Here is your working code with minor edit ( sign related ) : http://jsfiddle/qcVDc/1/