I am getting the above error with the example code below, I am quite new to nested ternary operations so your help would be appreciated. Example code below:

Car4 = {
  data: {
    CoverBasis: item.coverBasis() || "Client",
    IncludeInPackage: item.canBeIncludedInPackage() ?
      (item.includeInPackage() && totalPolicies > 1 ? "Yes" : "No") : "No"
  }
};

I am getting the above error with the example code below, I am quite new to nested ternary operations so your help would be appreciated. Example code below:

Car4 = {
  data: {
    CoverBasis: item.coverBasis() || "Client",
    IncludeInPackage: item.canBeIncludedInPackage() ?
      (item.includeInPackage() && totalPolicies > 1 ? "Yes" : "No") : "No"
  }
};

• javascript

Share Improve this question Follow edited Aug 13, 2021 at 9:36 pilchard 13k55 gold badges1212 silver badges2626 bronze badges asked Aug 13, 2021 at 9:35 aaishaaaisha 5111 gold badge22 silver badges33 bronze badges 1

• 4 You don't need this to be nested, it is 'yes' if all are true, or 'no' if any is false (in order) item.canBeIncludedInPackage() && item.includeInPackage() && totalPolicies > 1 ? "Yes" : "No"; – pilchard Commented Aug 13, 2021 at 10:03

Add a ment  | 

3 Answers 3

Sorted by: Reset to default 0

I think the error tells you to move the nester ternary operator totalPolicies > 1 ? "Yes" : "No" in the separated variable, like this:

const areTotalPoliciesBiggerOne = totalPolicies > 1 ? "Yes" : "No";
Car4 = {
  data: {
    CoverBasis: item.coverBasis() || "Client",
    IncludeInPackage: item.canBeIncludedInPackage() ?
      (item.includeInPackage() && areTotalPoliciesBiggerOne) : "No"
  }
};

I'm guessing it's sonarlint that throws warning/error. It's actually the dual nested ternary operator that increases the code plexity that's what sonarlint is suggesting IMO.

Doing it this way should solve the issue.

const itemIncludeInPackageAndTotalPolicies = (item.includeInPackage() && totalPolicies > 1 ? "Yes" : "No");

Car4 = {
  data: {
    CoverBasis: item.coverBasis() || "Client",
    IncludeInPackage: item.canBeIncludedInPackage() ?
      itemIncludeInPackageAndTotalPolicies : "No"
  }
};

You need to put yes or not in a <div></div>

 `totalPolicies > 1 ? <div>"Yes"</div>: 
<div>No</div>`