I am having a small issue with variable assignment. For some reason my line variable doesn't properly assign.

var records = new Array();
var recid = -5
var subrecid = 6495;
var line = new Array();
line['recid'] = recid;
line['subrecid'] = subrecid;
if (subrecid > 0) records.push(line);

I am having a small issue with variable assignment. For some reason my line variable doesn't properly assign.

var records = new Array();
var recid = -5
var subrecid = 6495;
var line = new Array();
line['recid'] = recid;
line['subrecid'] = subrecid;
if (subrecid > 0) records.push(line);

• javascript
• arrays

Share Improve this question Follow edited Dec 24, 2011 at 22:18 Ry-♦ 226k5656 gold badges493493 silver badges499499 bronze badges asked Dec 24, 2011 at 22:15 user1052933user1052933 19122 gold badges44 silver badges88 bronze badges 9

• 2 Actually, it does. Instead of checking what you think is the solution, can you provide a jsFiddle showing the error? – Ry- ♦ Commented Dec 24, 2011 at 22:17
• 2 How do you know it doesn't "assign"? What result are you expecting to get that you aren't getting? – Gareth Commented Dec 24, 2011 at 22:17
• 1 mind you that javascript does NOT have associative arrays. You can use the 1line['syntax'] because you are actually calling an object there, but there is associative array in javascript. It might be the fact you just init it as an array? – Nanne Commented Dec 24, 2011 at 22:20
• JavaScript doesn't need arrays for that, by the way; there's no such thing as a hash or associative array. You can use var line = {}; line.recid = recid; line.subrecid = subrecid; instead. – Ry- ♦ Commented Dec 24, 2011 at 22:22
• 1 @MДΓΓБДLL: Yeah, it depends on your definition. – Ry- ♦ Commented Dec 24, 2011 at 22:35

 |  Show 4 more ments

3 Answers 3

Sorted by: Reset to default 4

Don't use an array for non-integer indexing. Use an object. Also, it's generally better to use [] instead of new Array(). Oh yeah, and there's a line missing a semicolon.

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {}; // object, not array
line.recid = recid;
line.subrecid = subrecid;
if (subrecid > 0) records.push(line);

Even more concise:

var records = [];
var recid = -5;
var subrecid = 6495;
var line = {
    recid: recid,
    subrecid: subrecid
};
if (subrecid) records.push(line);

Matt's answer is fine, but you could take greater advantage of object literal syntax:

var records = [];
var line = {recid: -5, subrecid: 6495 };

if (line.subrecid > 0) records.push(line);

var val1=$('#Accountstype_account_c').val();