What am I doing wrong?

<input type='text' name='keyword' id='keyword' size='16'>

<a href= "" onclick="window.open('.getElementById('keyword')');">

it opens a new window with without q = keyword.

What am I doing wrong?

<input type='text' name='keyword' id='keyword' size='16'>

<a href= "" onclick="window.open('http://scholar.google./scholar?q=document.getElementById('keyword')');">

it opens a new window with without q = keyword.

• javascript
• html
• onclick
• window

Share Improve this question Follow edited Jul 10, 2012 at 19:56 LittleBobbyTables - Au Revoir 32.8k2525 gold badges111111 silver badges115115 bronze badges asked Jul 10, 2012 at 19:55 campatskycampatsky 32411 gold badge33 silver badges1414 bronze badges

Add a ment  | 

3 Answers 3

Sorted by: Reset to default 3

You need to have document.getElementById('keyword') as part of the code, not the hyperlink.

<input type='text' name='keyword' id='keyword' size='16'>  

<a href= "" 
    onclick="window.open('http://scholar.google./scholar?q=' + document.getElementById('keyword') + '');"> 

You have the getElementById enclosed in quotes.

It should be:

<a href="" onclick="window.open('http://scholar.google./scholar?q=' + document.getElementById('keyword').value);">

Declaring document.getElementById('keyword')doesn't automatically give you the value written in it. For that, you need to do document.getElementById('keyword').value.

What you probably want to do is this:

<a onclick="window.open('http://scholar.google./scholar?q=' + document.getElementById('keyword').value);">Click here</a>