I am having a hard time passing a string constant into an onchange event. code example which i am trying:

var rvalue = "hi";
var r1 = '<label style="vertical-align:2px;">Group by: </label>' +
    '<select id="pwx_documents_range_groupby" onchange="ravi('+rvalue+');">' +
    '<option value="listview" selected="selected">List View</option><option value="notetype">Note Type</option><option value="author">Author View</option>'+
    '<option value="cat">Cat</option></select>'

This is just sample code.. But the question is once drop down change it will call ravi function and throw me the error 'hi' is undefined. If i am passing 0 instead of hi it works great. I am totally surprise why it will not accept the string.

Anybody have any idea that would be great help.

I am having a hard time passing a string constant into an onchange event. code example which i am trying:

var rvalue = "hi";
var r1 = '<label style="vertical-align:2px;">Group by: </label>' +
    '<select id="pwx_documents_range_groupby" onchange="ravi('+rvalue+');">' +
    '<option value="listview" selected="selected">List View</option><option value="notetype">Note Type</option><option value="author">Author View</option>'+
    '<option value="cat">Cat</option></select>'

This is just sample code.. But the question is once drop down change it will call ravi function and throw me the error 'hi' is undefined. If i am passing 0 instead of hi it works great. I am totally surprise why it will not accept the string.

Anybody have any idea that would be great help.

• javascript

Share Improve this question Follow edited Jun 28, 2012 at 17:08 Joseph Marikle 78.7k1818 gold badges113113 silver badges130130 bronze badges asked Jun 28, 2012 at 17:07 raviravi 7111 gold badge33 silver badges1111 bronze badges 0

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 5

Either set rvalue = "'hi'" or quote it in the body: 'onchange="ravi(\''+rvalue+'\');">'

That is because rvalue is a string. You need to wrap strings with quotes. So it should be something like - onchange="ravi(\''+rvalue+'\');">'