I have been trying to figure this out for quite a while, hopefully someone can point out what is wrong.

I am trying to pile the HTML template because it does not call the function removeAllImages(). According to the console log for scope, I can see that the function is there.

Here is my directive:

musicianMarketplace.directive('slideshowImagesManage', ['$q', 'Auth', '$pile', 
  function ($q, Auth, $http, $location, $pile) {
    return {
        restrict: 'E',
        // scope: {
        //     slideshowImages: '=',
        //     // removeAllImages: '&',
        //     // removeImage: '&'
        // },
        // transclude: true,
        link: function ($scope, elem, attr) {

            console.log($scope);

            // slideshowImages = attr.slideshowImages;
            // removeAllImages = attr.removeAllImages;
            // removeImage = attr.removeImage;

            function updateImages() {
                $q.when($scope.slideshowImages).then(function (slideshowImages) {
                    elem.empty();
                    var html = '';
                    if (slideshowImages != null) {

                        html += '<div class="col-xs-12 col-sm-12 col-md-12 col-lg-12">';

                        html += '<div><a ng-href="" ng-click="removeAllImages(' + 
                                 Auth.getCurrentUser().id + 
                                ');">Remove All Images</a></div>';

                        $.each(slideshowImages, function (key, value) {
                            if (value.fd || value[0].fd) {
                                html += '<div class="col-xs-4 col-sm-4 col-md-4 col-lg-4">';
                                if (value.fd) {
                                    html += '<img ng-src="' + S3STORE + '/' + value.fd + 
                                            '" width="100%" alt="' + value.fd + '" />';
                                    html += '<a ng-href="" ng-click="removeImage({image: ' + 
                                            value.fd + '})">Remove</a>';
                                } else if (value[0].fd) {
                                    html += '<img ng-src="' + S3STORE + '/' + value[0].fd + 
                                            '" width="100%" alt="' + value[0].fd + '" />';
                                    html += '<a ng-href="" ng-click="removeImage({image: ' + 
                                            value[0].fd + '})">Remove</a>';
                                }
                                html += '</div>';
                            }
                        });

                        html += '</div>';

                        html = $pile(html)(scope);

                        elem.html(html);

                    } else {
                        html = "NO IMAGES";
                        elem.html(html);
                    }
                });
            }

            updateImages();

            $scope.$watch(attr.slideshowImages, function (newVal, oldVal) {
                if (newVal != oldVal) {
                    slideshowImages = newVal;
                    updateImages();
                }
            });

            $scope.$on('$destroy', function () {
                updateImages();
            });

        }
    };
}]);

As you can see I have tried with and without isolated scope. Everything else works except the function call.

The function itself I have just a console log:

$scope.removeAllImages = function (user) {
    console.log("HERE");
}

I have tried this HTML for isolated scope:

<slideshow-images-manage 
   slideshow-images="slideshowImages" 
   remove-all-images="removeAllImages(user)" 
   remove-image="removeImage(image)">
</slideshow-images-manage>

and this HTML for non-isolated scope:

<slideshow-images-manage></slideshow-images-manage>

I have been trying to figure this out for quite a while, hopefully someone can point out what is wrong.

I am trying to pile the HTML template because it does not call the function removeAllImages(). According to the console log for scope, I can see that the function is there.

Here is my directive:

musicianMarketplace.directive('slideshowImagesManage', ['$q', 'Auth', '$pile', 
  function ($q, Auth, $http, $location, $pile) {
    return {
        restrict: 'E',
        // scope: {
        //     slideshowImages: '=',
        //     // removeAllImages: '&',
        //     // removeImage: '&'
        // },
        // transclude: true,
        link: function ($scope, elem, attr) {

            console.log($scope);

            // slideshowImages = attr.slideshowImages;
            // removeAllImages = attr.removeAllImages;
            // removeImage = attr.removeImage;

            function updateImages() {
                $q.when($scope.slideshowImages).then(function (slideshowImages) {
                    elem.empty();
                    var html = '';
                    if (slideshowImages != null) {

                        html += '<div class="col-xs-12 col-sm-12 col-md-12 col-lg-12">';

                        html += '<div><a ng-href="" ng-click="removeAllImages(' + 
                                 Auth.getCurrentUser().id + 
                                ');">Remove All Images</a></div>';

                        $.each(slideshowImages, function (key, value) {
                            if (value.fd || value[0].fd) {
                                html += '<div class="col-xs-4 col-sm-4 col-md-4 col-lg-4">';
                                if (value.fd) {
                                    html += '<img ng-src="' + S3STORE + '/' + value.fd + 
                                            '" width="100%" alt="' + value.fd + '" />';
                                    html += '<a ng-href="" ng-click="removeImage({image: ' + 
                                            value.fd + '})">Remove</a>';
                                } else if (value[0].fd) {
                                    html += '<img ng-src="' + S3STORE + '/' + value[0].fd + 
                                            '" width="100%" alt="' + value[0].fd + '" />';
                                    html += '<a ng-href="" ng-click="removeImage({image: ' + 
                                            value[0].fd + '})">Remove</a>';
                                }
                                html += '</div>';
                            }
                        });

                        html += '</div>';

                        html = $pile(html)(scope);

                        elem.html(html);

                    } else {
                        html = "NO IMAGES";
                        elem.html(html);
                    }
                });
            }

            updateImages();

            $scope.$watch(attr.slideshowImages, function (newVal, oldVal) {
                if (newVal != oldVal) {
                    slideshowImages = newVal;
                    updateImages();
                }
            });

            $scope.$on('$destroy', function () {
                updateImages();
            });

        }
    };
}]);

As you can see I have tried with and without isolated scope. Everything else works except the function call.

The function itself I have just a console log:

$scope.removeAllImages = function (user) {
    console.log("HERE");
}

I have tried this HTML for isolated scope:

<slideshow-images-manage 
   slideshow-images="slideshowImages" 
   remove-all-images="removeAllImages(user)" 
   remove-image="removeImage(image)">
</slideshow-images-manage>

and this HTML for non-isolated scope:

<slideshow-images-manage></slideshow-images-manage>

• javascript
• angularjs
• angularjs-directive

Share Improve this question Follow edited Mar 8, 2017 at 21:53 Chait 1,37333 gold badges2222 silver badges3737 bronze badges asked Mar 8, 2017 at 20:03 joegod86joegod86 2011 silver badge33 bronze badges 0

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 6

The error is expected as you are not injecting dependencies properly in the directive.

Use

musicianMarketplace.directive('slideshowImagesManage', ['$q', 'Auth', '$pile', '$http', '$location', function ($q, Auth, $pile, $http, $location){

instead of

musicianMarketplace.directive('slideshowImagesManage', ['$q', 'Auth', '$pile', function ($q, Auth, $http, $location, $pile) { 

Your dependencies are not injected properly.

['$q', 'Auth', '$pile', function ($q, Auth, $http, $location, $pile) {...

In the string part, you failed to add '$http' and '$location' . Both the string part and the function arguments need to match up 1:1. Same services injected in the same order.