I'm using the following JS I found online to implement a responsive navigation. There is nothing on the source about having any errors in IE8, however I'm doing some patibility testing in BrowserStack (Win7+IE8) and getting the "Object doesn't support this property or method" error. Here is the entire script:

<script>
$(function() {  
    var pull        = $('#menu');  
        menu        = $('nav ul');  
        menuHeight  = menu.height();  

    $(pull).on('click', function(e) {  
        e.preventDefault();  
        menu.slideToggle();  
    });  
});  

$(window).resize(function(){  
    var w = $(window).width();  
    if(w > 320 && menu.is(':hidden')) {  
        menu.removeAttr('style');  
    }  
});
</script>

And this is the line that IE8 doesn't like (character 6 specifically):

if(w > 320 && menu.is(':hidden')) { 

Any help in solving this would be awesome, I'm still not the best at JS.

I'm using the following JS I found online to implement a responsive navigation. There is nothing on the source about having any errors in IE8, however I'm doing some patibility testing in BrowserStack (Win7+IE8) and getting the "Object doesn't support this property or method" error. Here is the entire script:

<script>
$(function() {  
    var pull        = $('#menu');  
        menu        = $('nav ul');  
        menuHeight  = menu.height();  

    $(pull).on('click', function(e) {  
        e.preventDefault();  
        menu.slideToggle();  
    });  
});  

$(window).resize(function(){  
    var w = $(window).width();  
    if(w > 320 && menu.is(':hidden')) {  
        menu.removeAttr('style');  
    }  
});
</script>

And this is the line that IE8 doesn't like (character 6 specifically):

if(w > 320 && menu.is(':hidden')) { 

Any help in solving this would be awesome, I'm still not the best at JS.

• javascript
• jquery
• internet-explorer-8

Share Follow edited Jun 5, 2014 at 20:25 IEcansuckit asked Jun 5, 2014 at 20:25 IEcansuckitIEcansuckit 3611 gold badge11 silver badge55 bronze badges 5

• 2 .resize() is an independent event and can occur before .ready(), before menu is defined. To avoid the race condition, you can bind the .resize() event within the .ready() handler. – Jonathan Lonowski Commented Jun 5, 2014 at 20:26
• Ah, yes. Move that function inside document.ready. – isherwood Commented Jun 5, 2014 at 20:27
• 3 This basically only works because you forgot to delimit your variables with ma and made them global ! – adeneo Commented Jun 5, 2014 at 20:28
• So I need to pull the variables outside of the first $(function ? – IEcansuckit Commented Jun 5, 2014 at 20:29
• Not really, you need to make them not global – adeneo Commented Jun 5, 2014 at 20:29

Add a ment  | 

2 Answers 2

Sorted by: Reset to default 2

I hope you realize that single var statement doesn't apply to all of the variables. You are declaring global variables.

Just stop storing jQuery objects in globals at all. It doesn't cost much to just create them upon demand and you don't get into this lifetime/scoping issue that you had:

<script>
$(function() {  
    $('#menu').on('click', function(e) {  
        e.preventDefault();  
        $('nav ul').slideToggle();  
    });  
});  

$(window).resize(function(){  
    var menu = $('nav ul'); 
    if($(window).width() > 320 && menu.is(':hidden')) {  
        menu.removeAttr('style');  
    }  
});
</script>

Some general design/code layout thoughts that apply here:

1. Avoid globals whenever possible.
2. Don't declare something in one scope and then try to use it in another scope (won't work unless global so see rule #1) and if global may have timing issues too.
3. Fetch selector results only when needed in the function where they are consumed. There is very, very rarely a reason to cache something like that beyond the lifetime of a function.
4. If you are going to refer to the same jQuery object more than once within a function, then you may want to save it into a local variable for the duration of the function (as long as its results won't be modified within the function).